From 8094f0cb0ce9c61f1e2638ad75ce45a677fe3c4a Mon Sep 17 00:00:00 2001 From: Andre Przywara Date: Mon, 13 Aug 2018 16:40:08 +0530 Subject: sunxi: A64: fix default DRAM_ODT_EN symbol "default" lines in Kconfig are processed in order, the first hit will stop considering subsequent lines. In the case of the DRAM_ODT_EN symbol that means that everything following the first two lines will never be checked: ------------ config DRAM_ODT_EN bool "sunxi dram odt enable" default n if !MACH_SUN8I_A23 default y if MACH_SUN8I_A23 default y if MACH_SUN8I_R40 default y if MACH_SUN50I ------------ Assuming that the "default y" for the A64 and the R40 were a deliberate choice, fix the Kconfig stanza to take this into account. Also remove the now redundant lines from the respective defconfigs. Signed-off-by: Andre Przywara [jagan: droped 'default n' on original change] Signed-off-by: Jagan Teki Acked-by: Maxime Ripard Tested-by: Jagan Teki # A64, R40 Tested-by: Chen-Yu Tsai # A23 --- configs/bananapi_m2_berry_defconfig | 1 - 1 file changed, 1 deletion(-) (limited to 'configs/bananapi_m2_berry_defconfig') diff --git a/configs/bananapi_m2_berry_defconfig b/configs/bananapi_m2_berry_defconfig index 313e09a764..c5c3cc3a90 100644 --- a/configs/bananapi_m2_berry_defconfig +++ b/configs/bananapi_m2_berry_defconfig @@ -4,7 +4,6 @@ CONFIG_SPL=y CONFIG_MACH_SUN8I_R40=y CONFIG_DRAM_CLK=576 CONFIG_DRAM_ZQ=3881979 -CONFIG_DRAM_ODT_EN=y CONFIG_MMC0_CD_PIN="PH13" CONFIG_DEFAULT_DEVICE_TREE="sun8i-v40-bananapi-m2-berry" CONFIG_AHCI=y -- cgit v1.2.3