From b75d8dc5642b71eb029e7cd38031a32029e736cc Mon Sep 17 00:00:00 2001 From: Masahiro Yamada Date: Fri, 26 Jun 2020 15:13:33 +0900 Subject: treewide: convert bd_t to struct bd_info by coccinelle The Linux coding style guide (Documentation/process/coding-style.rst) clearly says: It's a **mistake** to use typedef for structures and pointers. Besides, using typedef for structures is annoying when you try to make headers self-contained. Let's say you have the following function declaration in a header: void foo(bd_t *bd); This is not self-contained since bd_t is not defined. To tell the compiler what 'bd_t' is, you need to include #include void foo(bd_t *bd); Then, the include direcective pulls in more bloat needlessly. If you use 'struct bd_info' instead, it is enough to put a forward declaration as follows: struct bd_info; void foo(struct bd_info *bd); Right, typedef'ing bd_t is a mistake. I used coccinelle to generate this commit. The semantic patch that makes this change is as follows: @@ typedef bd_t; @@ -bd_t +struct bd_info Signed-off-by: Masahiro Yamada --- arch/arm/mach-omap2/am33xx/board.c | 2 +- arch/arm/mach-omap2/am33xx/fdt.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) (limited to 'arch/arm/mach-omap2/am33xx') diff --git a/arch/arm/mach-omap2/am33xx/board.c b/arch/arm/mach-omap2/am33xx/board.c index ce58bf811f2..a7b56b6bb3d 100644 --- a/arch/arm/mach-omap2/am33xx/board.c +++ b/arch/arm/mach-omap2/am33xx/board.c @@ -160,7 +160,7 @@ const struct gpio_bank *const omap_gpio_bank = gpio_bank_am33xx; #endif #if defined(CONFIG_MMC_OMAP_HS) -int cpu_mmc_init(bd_t *bis) +int cpu_mmc_init(struct bd_info *bis) { int ret; diff --git a/arch/arm/mach-omap2/am33xx/fdt.c b/arch/arm/mach-omap2/am33xx/fdt.c index c81dc808e5d..2ec30b1f9c3 100644 --- a/arch/arm/mach-omap2/am33xx/fdt.c +++ b/arch/arm/mach-omap2/am33xx/fdt.c @@ -14,7 +14,7 @@ #ifdef CONFIG_TI_SECURE_DEVICE -static void ft_hs_fixups(void *fdt, bd_t *bd) +static void ft_hs_fixups(void *fdt, struct bd_info *bd) { /* Check we are running on an HS/EMU device type */ if (GP_DEVICE != get_device_type()) { @@ -29,7 +29,7 @@ static void ft_hs_fixups(void *fdt, bd_t *bd) hang(); } #else -static void ft_hs_fixups(void *fdt, bd_t *bd) { } +static void ft_hs_fixups(void *fdt, struct bd_info *bd) { } #endif /* #ifdef CONFIG_TI_SECURE_DEVICE */ /* @@ -37,7 +37,7 @@ static void ft_hs_fixups(void *fdt, bd_t *bd) { } * fixups should remain in the board files which is where * this function should be called from. */ -void ft_cpu_setup(void *fdt, bd_t *bd) +void ft_cpu_setup(void *fdt, struct bd_info *bd) { ft_hs_fixups(fdt, bd); } -- cgit v1.2.3