summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorMarek Vasut <marex@denx.de>2013-12-04 14:27:40 +0100
committerStefano Babic <sbabic@denx.de>2013-12-17 18:38:43 +0100
commit5b5a82eb7054869e869c2aa3c7018fe50a84c47a (patch)
treec5d38668331036fe3be76135ac080e4042fb310f /tools
parent119e9909869ee3e2a994a01130014b93fade3bcc (diff)
ARM: mxs: tools: Fix errno handling in strtoul() invocation
According to NOTE in strtoul(3), the errno must be zeroed before strtoul() is called. Zero the errno. The NOTE reads as such: Since strtoul() can legitimately return 0 or ULONG_MAX (ULLONG_MAX for strtoull()) on both success and failure, the calling program should set errno to 0 before the call, and then determine if an error occurred by checking whether errno has a nonzero value after the call. This issue was detected on Fedora 19 with glibc 2.17 . Signed-off-by: Marek Vasut <marex@denx.de> Cc: Stefano Babic <sbabic@denx.de> Cc: Tom Rini <trini@ti.com>
Diffstat (limited to 'tools')
-rw-r--r--tools/mxsimage.c1
1 files changed, 1 insertions, 0 deletions
diff --git a/tools/mxsimage.c b/tools/mxsimage.c
index 5db19b216fa..7bd9deef5f0 100644
--- a/tools/mxsimage.c
+++ b/tools/mxsimage.c
@@ -502,6 +502,7 @@ static int sb_token_to_long(char *tok, uint32_t *rid)
tok += 2;
+ errno = 0;
id = strtoul(tok, &endptr, 16);
if ((errno == ERANGE && id == ULONG_MAX) || (errno != 0 && id == 0)) {
fprintf(stderr, "ERR: Value can't be decoded!\n");