summaryrefslogtreecommitdiff
path: root/tools
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2018-10-01 21:12:42 -0600
committerSimon Glass <sjg@chromium.org>2018-10-08 07:34:34 -0600
commit86af511d892df59f06bf49a71505a072ea2cd5f3 (patch)
tree80f2d24a57b6c551c1c3704ebf3e40a7ea3deb91 /tools
parente0e6275f4c6cbcf2b975dbd9771b14f21eb51a36 (diff)
binman: Separate out testSplBssPad()
At present this test runs binman twice, which means that the temporary files from the first run do not get cleaned up. Split this into two tests to fix this problem. Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools')
-rw-r--r--tools/binman/ftest.py4
1 files changed, 3 insertions, 1 deletions
diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py
index 9ef259a699b..ed787745606 100644
--- a/tools/binman/ftest.py
+++ b/tools/binman/ftest.py
@@ -1022,10 +1022,12 @@ class TestFunctional(unittest.TestCase):
data = self._DoReadFile('47_spl_bss_pad.dts')
self.assertEqual(U_BOOT_SPL_DATA + (chr(0) * 10) + U_BOOT_DATA, data)
+ def testSplBssPadMissing(self):
+ """Test that a missing symbol is detected"""
with open(self.TestFile('u_boot_ucode_ptr')) as fd:
TestFunctional._MakeInputFile('spl/u-boot-spl', fd.read())
with self.assertRaises(ValueError) as e:
- data = self._DoReadFile('47_spl_bss_pad.dts')
+ self._DoReadFile('47_spl_bss_pad.dts')
self.assertIn('Expected __bss_size symbol in spl/u-boot-spl',
str(e.exception))