diff options
| author | Simon Glass <sjg@chromium.org> | 2022-02-08 10:59:44 -0700 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2022-02-22 10:05:44 -0700 |
| commit | 8db1f9958ff7dfc54ef673607d47694dd672dae7 (patch) | |
| tree | 09d342b28720857e65161e7747ac34b270394d37 /tools | |
| parent | 730922205b107acb80e51ee3c9e2e244ba8968b8 (diff) | |
binman: Correct the error message for a bad hash algorithm
This shows an internal type at present, rather than the algorithm name.
Fix it and update the test to catch this.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Alper Nebi Yasak <alpernebiyasak@gmail.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/binman/ftest.py | 2 | ||||
| -rw-r--r-- | tools/binman/state.py | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/tools/binman/ftest.py b/tools/binman/ftest.py index f8e73c6f9b..4616a29deb 100644 --- a/tools/binman/ftest.py +++ b/tools/binman/ftest.py @@ -2076,7 +2076,7 @@ class TestFunctional(unittest.TestCase): def testHashBadAlgo(self): with self.assertRaises(ValueError) as e: self._DoReadFileDtb('092_hash_bad_algo.dts', update_dtb=True) - self.assertIn("Node '/binman/u-boot': Unknown hash algorithm", + self.assertIn("Node '/binman/u-boot': Unknown hash algorithm 'invalid'", str(e.exception)) def testHashSection(self): diff --git a/tools/binman/state.py b/tools/binman/state.py index 8cd8a48318..a302e1f00e 100644 --- a/tools/binman/state.py +++ b/tools/binman/state.py @@ -397,7 +397,7 @@ def CheckAddHashProp(node): if algo.value == 'sha256': size = 32 else: - return "Unknown hash algorithm '%s'" % algo + return "Unknown hash algorithm '%s'" % algo.value for n in GetUpdateNodes(hash_node): n.AddEmptyProp('value', size) |