diff options
| author | Simon Glass <sjg@chromium.org> | 2016-06-30 10:52:19 -0600 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2016-07-14 18:22:31 -0400 |
| commit | 51f03e6a7596d61a9ae9b1aee030112cc6a795ff (patch) | |
| tree | f076c66048860f408db5c510ffb79af7779ed793 /tools | |
| parent | f24e10500ffc7ff4b9c75de0e9b1f3efdd43ef41 (diff) | |
mkimage: Show item lists for all categories
Update the error-handling code for -A, -C and -O to show a list of valid
options when an invalid one is provided.
Signed-off-by: Simon Glass <sjg@chromium.org>
Reported-by: Vinoth Eswaran <evinoth1206@gmail.com>
Reviewed-by: Tom Rini <trini@konsulko.com>
Diffstat (limited to 'tools')
| -rw-r--r-- | tools/mkimage.c | 12 |
1 files changed, 9 insertions, 3 deletions
diff --git a/tools/mkimage.c b/tools/mkimage.c index 3cdbb2cfcd..f589a418ee 100644 --- a/tools/mkimage.c +++ b/tools/mkimage.c @@ -152,8 +152,10 @@ static void process_args(int argc, char **argv) break; case 'A': params.arch = genimg_get_arch_id(optarg); - if (params.arch < 0) + if (params.arch < 0) { + show_valid_options(IH_ARCH); usage("Invalid architecture"); + } break; case 'b': if (add_content(IH_TYPE_FLATDT, optarg)) { @@ -168,8 +170,10 @@ static void process_args(int argc, char **argv) break; case 'C': params.comp = genimg_get_comp_id(optarg); - if (params.comp < 0) + if (params.comp < 0) { + show_valid_options(IH_COMP); usage("Invalid compression type"); + } break; case 'd': params.datafile = optarg; @@ -216,8 +220,10 @@ static void process_args(int argc, char **argv) break; case 'O': params.os = genimg_get_os_id(optarg); - if (params.os < 0) + if (params.os < 0) { + show_valid_options(IH_OS); usage("Invalid operating system"); + } break; case 'p': params.external_offset = strtoull(optarg, &ptr, 16); |