summaryrefslogtreecommitdiff
path: root/tools/buildman
diff options
context:
space:
mode:
authorStephen Warren <swarren@nvidia.com>2013-10-09 14:28:09 -0600
committerSimon Glass <sjg@chromium.org>2013-10-10 10:40:42 -0600
commit8bb2bddc2c18a3643ce53e793d5bc27a40e98a4f (patch)
tree22845d0426931f5fdf5074081e5856cac237c310 /tools/buildman
parent99b4eaa68e0e2fdd9b0d0b1d40809d7e8f92044f (diff)
buildman: don't fail --list-toolchains when toolchains fail
When a toolchain invocation fails, an exception is thrown but not caught which then aborts the entire toolchain detection process. To solve this, request that exceptions not be thrown, since the toolchain init code already error-checks the command result. This solves e.g.: - found '/usr/bin/winegcc' Traceback (most recent call last): ... Exception: Error running '/usr/bin/winegcc --version' Change-Id: I579c72ab3b021e38b14132893c3375ea257c74f0 Signed-off-by: Stephen Warren <swarren@nvidia.com> Acked-by: Simon Glass <sjg@chromium.org> Signed-off-by: Simon Glass <sjg@chromium.org> (formatted to 80cols)
Diffstat (limited to 'tools/buildman')
-rw-r--r--tools/buildman/toolchain.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/buildman/toolchain.py b/tools/buildman/toolchain.py
index a292338b6d0..b64338680e9 100644
--- a/tools/buildman/toolchain.py
+++ b/tools/buildman/toolchain.py
@@ -39,7 +39,8 @@ class Toolchain:
# As a basic sanity check, run the C compiler with --version
cmd = [fname, '--version']
if test:
- result = command.RunPipe([cmd], capture=True, env=env)
+ result = command.RunPipe([cmd], capture=True, env=env,
+ raise_on_error=False)
self.ok = result.return_code == 0
if verbose:
print 'Tool chain test: ',