diff options
| author | Simon Glass <sjg@chromium.org> | 2018-08-01 15:22:37 -0600 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2018-08-01 16:30:06 -0600 |
| commit | 3ab9598df714556b649048b2a387071253e9e731 (patch) | |
| tree | 55a61a2125ff40b15a96e47104402f06a91f5eb9 /tools/binman/elf.py | |
| parent | 46d61a2f2aeefcd622c9678716429e68a3a98811 (diff) | |
binman: Rename 'position' to 'offset'
After some thought, I believe there is an unfortunate naming flaw in
binman. Entries have a position and size, but now that we support
hierarchical sections it is unclear whether a position should be an
absolute position within the image, or a relative position within its
parent section.
At present 'position' actually means the relative position. This indicates
a need for an 'image position' for code that wants to find the location of
an entry without having to do calculations back through parents to
discover this image position.
A better name for the current 'position' or 'pos' is 'offset'. It is not
always an absolute position, but it is always an offset from its parent
offset.
It is unfortunate to rename this concept now, 18 months after binman was
introduced. However I believe it is the right thing to do. The impact is
mostly limited to binman itself and a few changes to in-tree users to
binman:
tegra
sunxi
x86
The change makes old binman definitions (e.g. downstream or out-of-tree)
incompatible if they use the 'pos = <...>' property. Later work will
adjust binman to generate an error when it is used.
Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/binman/elf.py')
| -rw-r--r-- | tools/binman/elf.py | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/tools/binman/elf.py b/tools/binman/elf.py index 8c23040d8c..97df8e32c5 100644 --- a/tools/binman/elf.py +++ b/tools/binman/elf.py @@ -81,9 +81,9 @@ def LookupAndWriteSymbols(elf_fname, entry, section): """Replace all symbols in an entry with their correct values The entry contents is updated so that values for referenced symbols will be - visible at run time. This is done by finding out the symbols positions in - the entry (using the ELF file) and replacing them with values from binman's - data structures. + visible at run time. This is done by finding out the symbols offsets in the + entry (using the ELF file) and replacing them with values from binman's data + structures. Args: elf_fname: Filename of ELF image containing the symbol information for |