summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorStephen Warren <swarren@wwwdotorg.org>2016-02-15 17:40:34 -0700
committerTom Rini <trini@konsulko.com>2016-02-26 08:42:12 -0500
commit24862c640ea50ac88be343161eb681bea5dbfeef (patch)
tree0301e6edaaaf80d14952cd287b248c626e8f80f5 /test
parent38831ca3be7dee0f1b744304137d623b7c7b94bf (diff)
test/py: skip tests that require large CONFIG_SYS_MAXARGS
test_hush_if_test.py executes commands that require large values of CONFIG_SYS_MAXARGS. Detect cases where the configured value is too low and skip those tests. Ideally, this would be implemented inside console.run_command(). However, the command passed to that function is already a completely formed string, and determining its argument count usage would require splitting commands at ;, handling quoting to deal with arguments containing spaces, etc. Even passing the command as a list wouldn't solve all these issues, since we'd still need to split commands on ; and deal with cases like "if test ..." which consumes 0 of the argument count. Signed-off-by: Stephen Warren <swarren@wwwdotorg.org> Acked-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'test')
-rw-r--r--test/py/tests/test_hush_if_test.py8
1 files changed, 8 insertions, 0 deletions
diff --git a/test/py/tests/test_hush_if_test.py b/test/py/tests/test_hush_if_test.py
index 8b88425a659..1eeaa5b0471 100644
--- a/test/py/tests/test_hush_if_test.py
+++ b/test/py/tests/test_hush_if_test.py
@@ -97,6 +97,14 @@ subtests = (
def exec_hush_if(u_boot_console, expr, result):
"""Execute a shell "if" command, and validate its result."""
+ config = u_boot_console.config.buildconfig
+ maxargs = int(config.get('config_sys_maxargs', '0'))
+ args = len(expr.split(' ')) - 1
+ if args > maxargs:
+ u_boot_console.log.warning('CONFIG_SYS_MAXARGS too low; need ' +
+ str(args))
+ pytest.skip()
+
cmd = 'if ' + expr + '; then echo true; else echo false; fi'
response = u_boot_console.run_command(cmd)
assert response.strip() == str(result).lower()