summaryrefslogtreecommitdiff
path: root/test
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2014-07-23 06:55:11 -0600
committerSimon Glass <sjg@chromium.org>2014-07-23 14:07:25 +0100
commit4e8bc211703d3c93689367745e8c07dc22c68dfc (patch)
tree837773c2e9868b4b0144f8cb487c550e71937db3 /test
parentfffa24d7c5998a5821c423ef07bdbc8c4d7bdcf1 (diff)
dm: Avoid activating devices in 'dm uclass' command
This command currently activates devices as it lists them. This is not desirable since it changes the system state. Fix it and avoid printing a newline if there are no devices in a uclass. Signed-off-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'test')
-rw-r--r--test/dm/cmd_dm.c6
1 files changed, 3 insertions, 3 deletions
diff --git a/test/dm/cmd_dm.c b/test/dm/cmd_dm.c
index 9b77a7fb920..93e525579d7 100644
--- a/test/dm/cmd_dm.c
+++ b/test/dm/cmd_dm.c
@@ -94,9 +94,9 @@ static int do_dm_dump_uclass(cmd_tbl_t *cmdtp, int flag, int argc,
continue;
printf("uclass %d: %s\n", id, uc->uc_drv->name);
- for (ret = uclass_first_device(id, &dev);
- dev;
- ret = uclass_next_device(&dev)) {
+ if (list_empty(&uc->dev_head))
+ continue;
+ list_for_each_entry(dev, &uc->dev_head, uclass_node) {
dm_display_line(dev, "");
}
puts("\n");