summaryrefslogtreecommitdiff
path: root/drivers/phy
diff options
context:
space:
mode:
authorAdam Ford <aford173@gmail.com>2022-02-19 17:08:43 -0600
committerMarek Vasut <marex@denx.de>2022-02-23 05:25:17 +0100
commitf9852acdce029edb8e1a06d1d5336b6d0a12471e (patch)
tree3963f92e3020498b17fc38f6aa0bb2a01b9a3e29 /drivers/phy
parentac0c125b7e1ae028fff0d1528351a7272de9ec2b (diff)
phy: nop-phy: Fix enabling reset
The reset function should place the phy into reset, while the init function should take the phy out of reset. Currently the reset function takes it out of reset, and the init calls the reset. Signed-off-by: Adam Ford <aford173@gmail.com>
Diffstat (limited to 'drivers/phy')
-rw-r--r--drivers/phy/nop-phy.c5
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/phy/nop-phy.c b/drivers/phy/nop-phy.c
index b08eedd4d4..e2ee6e9206 100644
--- a/drivers/phy/nop-phy.c
+++ b/drivers/phy/nop-phy.c
@@ -28,7 +28,7 @@ static int nop_phy_reset(struct phy *phy)
if (!dm_gpio_is_valid(&priv->reset_gpio))
return 0;
- return dm_gpio_set_value(&priv->reset_gpio, false);
+ return dm_gpio_set_value(&priv->reset_gpio, true);
}
#endif
@@ -44,7 +44,8 @@ static int nop_phy_init(struct phy *phy)
}
#if CONFIG_IS_ENABLED(DM_GPIO)
- ret = nop_phy_reset(phy);
+ /* Take phy out of reset */
+ ret = dm_gpio_set_value(&priv->reset_gpio, false);
if (ret) {
if (CONFIG_IS_ENABLED(CLK))
clk_disable_bulk(&priv->bulk);