diff options
| author | Phil Edworthy <PHIL.EDWORTHY@renesas.com> | 2016-12-12 15:27:12 +0000 |
|---|---|---|
| committer | Joe Hershberger <joe.hershberger@ni.com> | 2017-02-07 10:54:34 -0600 |
| commit | 3b5f52801d5de89e39b95ac155cbcda44d164240 (patch) | |
| tree | 572666293b47955bfa2c3bc526535705bc015099 /drivers/net/phy/vitesse.c | |
| parent | 24d98cb42473e8842d6f29854cb1b2b4249bcfbd (diff) | |
net: phy: vitesse: Fix cis8204 RGMII_ID code
Commit 79e86ccb3786c8b20004db3fa10a70049456f580 "vitesse: remove duplicated
argument to ||" correctly removed a redundant check.
However, I believe that the original code was simply wrong, and should have
been checking against RGMII_ID.
To fix this and avoid similar problems in the future, use the
phy_interface_is_rgmii helper function.
Signed-off-by: Phil Edworthy <phil.edworthy@renesas.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Diffstat (limited to 'drivers/net/phy/vitesse.c')
| -rw-r--r-- | drivers/net/phy/vitesse.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/net/phy/vitesse.c b/drivers/net/phy/vitesse.c index a077b98d8c..e5e9922b30 100644 --- a/drivers/net/phy/vitesse.c +++ b/drivers/net/phy/vitesse.c @@ -127,9 +127,7 @@ static int cis8204_config(struct phy_device *phydev) genphy_config_aneg(phydev); - if ((phydev->interface == PHY_INTERFACE_MODE_RGMII) || - (phydev->interface == PHY_INTERFACE_MODE_RGMII_TXID) || - (phydev->interface == PHY_INTERFACE_MODE_RGMII_RXID)) + if (phy_interface_is_rgmii(phydev)) phy_write(phydev, MDIO_DEVAD_NONE, MIIM_CIS8204_EPHY_CON, MIIM_CIS8204_EPHYCON_INIT | MIIM_CIS8204_EPHYCON_RGMII); |