diff options
| author | Etienne Carriere <etienne.carriere@linaro.org> | 2021-11-08 08:56:08 +0100 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2021-11-23 13:53:03 -0500 |
| commit | 7b4993907a8c6839b14a769b98d56dddbf7cbe88 (patch) | |
| tree | 6b4371b8f8f491eee720822c5bf2bf1e1e12f92d /drivers/firmware | |
| parent | 5ddbbd19576c33f584da056c78778268dcb6ad67 (diff) | |
firmware: scmi: mailbox transport: fix probe failure implementation
Correct scmi mailbox probe function that can't free the scmi channel
instance since its auto-allocated by the device model framework.
Cc: Simon Glass <sjg@chromium.org>
Cc: Patrice Chotard <patrice.chotard@foss.st.com>
Cc: Patrick Delaunay <patrick.delaunay@foss.st.com>
Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org>
Reviewed-by: Patrick Delaunay <patrick.delaunay@foss.st.com>
Diffstat (limited to 'drivers/firmware')
| -rw-r--r-- | drivers/firmware/scmi/mailbox_agent.c | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/drivers/firmware/scmi/mailbox_agent.c b/drivers/firmware/scmi/mailbox_agent.c index ea35e7e09e..eb841d692b 100644 --- a/drivers/firmware/scmi/mailbox_agent.c +++ b/drivers/firmware/scmi/mailbox_agent.c @@ -72,17 +72,13 @@ int scmi_mbox_probe(struct udevice *dev) ret = mbox_get_by_index(dev, 0, &chan->mbox); if (ret) { dev_err(dev, "Failed to find mailbox: %d\n", ret); - goto out; + return ret; } ret = scmi_dt_get_smt_buffer(dev, &chan->smt); if (ret) dev_err(dev, "Failed to get shm resources: %d\n", ret); -out: - if (ret) - devm_kfree(dev, chan); - return ret; } |