summaryrefslogtreecommitdiff
path: root/common
diff options
context:
space:
mode:
authorNishanth Menon <nm@ti.com>2021-10-19 12:32:29 -0500
committerTom Rini <trini@konsulko.com>2021-12-01 16:28:45 -0500
commit6d99f866952bb5df7fe699b3db29a97d75e5c445 (patch)
treedbd895067824be9bfa258710e4869d3573314b88 /common
parentaf13df7014d7dc78b5461b65de78ca5096e5701c (diff)
spl: fit: Skip attempting to load 0 length image
When, for various reasons, a bad FIT image is used where a loadable image is marked as 0 length, attempt is made for a 0 length allocation and read of 0 byte read operation. Instead provide warning in log and skip attempting to do such a load. Signed-off-by: Nishanth Menon <nm@ti.com> Reviewed-by: Aswath Govindraju <a-govindraju@ti.com>
Diffstat (limited to 'common')
-rw-r--r--common/spl/spl_fit.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/common/spl/spl_fit.c b/common/spl/spl_fit.c
index 5fe0273d66..774072b85c 100644
--- a/common/spl/spl_fit.c
+++ b/common/spl/spl_fit.c
@@ -286,6 +286,13 @@ static int spl_load_fit_image(struct spl_load_info *info, ulong sector,
if (fit_image_get_data_size(fit, node, &len))
return -ENOENT;
+ /* Dont bother to copy 0 byte data, but warn, though */
+ if (!len) {
+ log_warning("%s: Skip load '%s': image size is 0!\n",
+ __func__, fit_get_name(fit, node, NULL));
+ return 0;
+ }
+
src_ptr = map_sysmem(ALIGN(load_addr, ARCH_DMA_MINALIGN), len);
length = len;