summaryrefslogtreecommitdiff
path: root/common/usb_hub.c
diff options
context:
space:
mode:
authorStephen Warren <swarren@wwwdotorg.org>2015-04-08 21:27:49 -0600
committerMarek Vasut <marex@denx.de>2015-04-14 05:47:48 +0200
commit25c0673635da1bef75ab5a9d852f92e0f0b581df (patch)
treea9775543b080f9f2046beda702aa02c8dffe97a5 /common/usb_hub.c
parent04ee6ee2ca5ad419ebcbc64dae6e7128f32156fd (diff)
usb: fix first descriptor fetch error handling
When fetching the first descriptor from a new device, only validate that we received at least 8 bytes, not that we received the entire descriptor. The reasoning is: - The code only uses fields in the first 8 bytes, so that's all we need to have fetched at this stage. - The smallest maxpacket size is 8 bytes. Before we know the actual maxpacket the device uses, the USB controller may only accept a single packet (see the DWC2 note in the comment added in the commit). Consequently we are only guaranteed to receive 1 packet (at least 8 bytes) even in a non-error case. Fixes: 1a7758044b04 ("usb: Early failure when the first descriptor read fails or is invalid") Cc: Paul Kocialkowski <contact@paulk.fr> Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
Diffstat (limited to 'common/usb_hub.c')
0 files changed, 0 insertions, 0 deletions