summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMiquel Raynal <miquel.raynal@bootlin.com>2019-05-07 14:18:49 +0200
committerTom Rini <trini@konsulko.com>2019-07-11 10:05:15 -0400
commitf30765b74896bcd604decc46e341035f7f3b4961 (patch)
tree24350538a191af1cb4a64bf77fa06d2df9e61ade
parent76bdaaa196be0c45c7933127fb33c8f9c23f541d (diff)
arm: spear: Use PUSH/POP mnemonics when relevant
Quoting ARM "RealView Compilation Tools Assembler Guide v4.0": PUSH and POP are synonyms for STMDB and LDM (or LDMIA), with the base register sp (r13), and the adjusted address written back to the base register. PUSH and POP are the preferred mnemonic in these cases. Let's follow this recommandation to ease the reading and substitute LDMIA/STMDB operations with PUSH/POP mnemonics. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Reviewed-by: Stefan Roese <sr@denx.de>
-rw-r--r--arch/arm/cpu/arm926ejs/spear/start.S8
1 files changed, 4 insertions, 4 deletions
diff --git a/arch/arm/cpu/arm926ejs/spear/start.S b/arch/arm/cpu/arm926ejs/spear/start.S
index 566cf668b71..25895f01acf 100644
--- a/arch/arm/cpu/arm926ejs/spear/start.S
+++ b/arch/arm/cpu/arm926ejs/spear/start.S
@@ -35,9 +35,9 @@ reset:
* SPL has to return back to BootROM in a few cases (eg. Ethernet boot,
* UART boot, USB boot): save registers in BootROM's stack.
*/
- stmdb sp!, {r0-r12,r14}
+ push {r0-r12,r14}
bl cpu_init_crit
- ldmia sp!, {r0-r12,pc}
+ pop {r0-r12,pc}
/*
*************************************************************************
@@ -67,6 +67,6 @@ cpu_init_crit:
/*
* Go setup Memory and board specific bits prior to relocation.
*/
- stmdb sp!, {lr}
+ push {lr}
bl _main /* _main will call board_init_f */
- ldmia sp!, {pc}
+ pop {pc}