diff options
| author | Lukasz Majewski <lukma@denx.de> | 2018-12-03 10:20:47 +0100 |
|---|---|---|
| committer | Stefano Babic <sbabic@denx.de> | 2019-01-01 14:12:18 +0100 |
| commit | 254409dbe836633b079968c0e7686ecd09b45dc7 (patch) | |
| tree | 3eb0f5ab44a7961886b74fa8be3dcd10263e673c | |
| parent | f026c1d9ef1cd20e966f57f53de25cb124ac2413 (diff) | |
nand: vybrid: Use calloc() instead of malloc() to allocate struct nfc
Without this change it is possible that Vybrid's NFC driver malloc() call
will obtain some memory used (and correctly free'd) by some previous
driver (in this case pinctrl for Vybrid).
As a result some fields of struct nfc - in out case mtd->_get_device - are
"pre initialized" with some random values.
On the latter stage of booting, when e.g. somebody calls 'mtdparts default'
the "data abort" is observed when __get_mtd_device() function is called.
The mtd->_get_device pointer is not NULL and wrong value is referenced.
Signed-off-by: Lukasz Majewski <lukma@denx.de>
Reviewed-by: Stefan Agner <stefan.agner@toradex.com>
| -rw-r--r-- | drivers/mtd/nand/raw/vf610_nfc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/mtd/nand/raw/vf610_nfc.c b/drivers/mtd/nand/raw/vf610_nfc.c index 619d0403e92..9baf5fa37a9 100644 --- a/drivers/mtd/nand/raw/vf610_nfc.c +++ b/drivers/mtd/nand/raw/vf610_nfc.c @@ -641,7 +641,7 @@ static int vf610_nfc_nand_init(int devnum, void __iomem *addr) .flash_bbt = 1, }; - nfc = malloc(sizeof(*nfc)); + nfc = calloc(1, sizeof(*nfc)); if (!nfc) { printf(KERN_ERR "%s: Memory exhausted!\n", __func__); return -ENOMEM; |