summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorStefan Agner <stefan.agner@toradex.com>2016-09-28 11:29:28 +0200
committerStefano Babic <sbabic@denx.de>2016-10-07 15:56:52 +0200
commitd7255e8ddbfe76d7b0d18247d35742596c85ad93 (patch)
tree4b90281e554dd71ca5be7156833b4c2ecbe4146d
parentd429557c64a911f076b3fa87761ca94121105f5a (diff)
ARM: vf610: use strcpy for soc environment variable
To create the soc environment variable we concatenate two strings on the stack. So far, strcat has been used for the first string as well as for the second string. Since the variable on the stack is not initialized, the first strcat may not start using the first entry in the character array. This then could lead to an buffer overflow on the stack. Signed-off-by: Stefan Agner <stefan.agner@toradex.com> Acked-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
-rw-r--r--arch/arm/cpu/armv7/vf610/generic.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/arch/arm/cpu/armv7/vf610/generic.c b/arch/arm/cpu/armv7/vf610/generic.c
index 08b9ef42a1..50eb0c6b97 100644
--- a/arch/arm/cpu/armv7/vf610/generic.c
+++ b/arch/arm/cpu/armv7/vf610/generic.c
@@ -322,7 +322,7 @@ int arch_misc_init(void)
{
char soc[6];
- strcat(soc, "vf");
+ strcpy(soc, "vf");
strcat(soc, soc_type);
setenv("soc", soc);