From 71a1c0125f132b2a4656689ca585c5d8931e539c Mon Sep 17 00:00:00 2001 From: Al Viro Date: Mon, 26 Jul 2010 11:25:05 +0400 Subject: logfs get_sb massage, part 1 move allocation of logfs_super to logfs_get_sb, pass it to logfs_get_sb_...(). Signed-off-by: Al Viro --- fs/logfs/dev_bdev.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) (limited to 'fs/logfs/dev_bdev.c') diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index 9bd2ce2a3040..bca8e2a8e55b 100644 --- a/fs/logfs/dev_bdev.c +++ b/fs/logfs/dev_bdev.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #define PAGE_OFS(ofs) ((ofs) & (PAGE_SIZE-1)) @@ -320,20 +321,23 @@ static const struct logfs_device_ops bd_devops = { .put_device = bdev_put_device, }; -int logfs_get_sb_bdev(struct file_system_type *type, int flags, +int logfs_get_sb_bdev(struct logfs_super *p, + struct file_system_type *type, int flags, const char *devname, struct vfsmount *mnt) { struct block_device *bdev; bdev = open_bdev_exclusive(devname, FMODE_READ|FMODE_WRITE, type); - if (IS_ERR(bdev)) + if (IS_ERR(bdev)) { + kfree(p); return PTR_ERR(bdev); + } if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) { int mtdnr = MINOR(bdev->bd_dev); close_bdev_exclusive(bdev, FMODE_READ|FMODE_WRITE); - return logfs_get_sb_mtd(type, flags, mtdnr, mnt); + return logfs_get_sb_mtd(p, type, flags, mtdnr, mnt); } - return logfs_get_sb_device(type, flags, NULL, bdev, &bd_devops, mnt); + return logfs_get_sb_device(p, type, flags, NULL, bdev, &bd_devops, mnt); } -- cgit v1.2.3 From 0d85c799623cb6022adb1317ed2987ab9c097c2e Mon Sep 17 00:00:00 2001 From: Al Viro Date: Mon, 26 Jul 2010 11:33:39 +0400 Subject: logfs get_sb, part 2 take setting s_bdev/s_mtd/s_devops to callers of logfs_get_sb_device(), don't bother passing them separately Signed-off-by: Al Viro --- fs/logfs/dev_bdev.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'fs/logfs/dev_bdev.c') diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index bca8e2a8e55b..a322fec10173 100644 --- a/fs/logfs/dev_bdev.c +++ b/fs/logfs/dev_bdev.c @@ -339,5 +339,9 @@ int logfs_get_sb_bdev(struct logfs_super *p, return logfs_get_sb_mtd(p, type, flags, mtdnr, mnt); } - return logfs_get_sb_device(p, type, flags, NULL, bdev, &bd_devops, mnt); + p->s_bdev = bdev; + p->s_mtd = NULL; + p->s_devops = &bd_devops; + + return logfs_get_sb_device(p, type, flags, mnt); } -- cgit v1.2.3 From 7d945a3aa7608f68dba04083d3421e0b43052660 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Mon, 26 Jul 2010 11:53:30 +0400 Subject: logfs get_sb, part 3 take logfs_get_sb_device() calls to logfs_get_sb() itself Signed-off-by: Al Viro --- fs/logfs/dev_bdev.c | 15 +++++---------- 1 file changed, 5 insertions(+), 10 deletions(-) (limited to 'fs/logfs/dev_bdev.c') diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index a322fec10173..223b673dcc7b 100644 --- a/fs/logfs/dev_bdev.c +++ b/fs/logfs/dev_bdev.c @@ -9,7 +9,6 @@ #include #include #include -#include #include #define PAGE_OFS(ofs) ((ofs) & (PAGE_SIZE-1)) @@ -321,27 +320,23 @@ static const struct logfs_device_ops bd_devops = { .put_device = bdev_put_device, }; -int logfs_get_sb_bdev(struct logfs_super *p, - struct file_system_type *type, int flags, - const char *devname, struct vfsmount *mnt) +int logfs_get_sb_bdev(struct logfs_super *p, struct file_system_type *type, + const char *devname) { struct block_device *bdev; bdev = open_bdev_exclusive(devname, FMODE_READ|FMODE_WRITE, type); - if (IS_ERR(bdev)) { - kfree(p); + if (IS_ERR(bdev)) return PTR_ERR(bdev); - } if (MAJOR(bdev->bd_dev) == MTD_BLOCK_MAJOR) { int mtdnr = MINOR(bdev->bd_dev); close_bdev_exclusive(bdev, FMODE_READ|FMODE_WRITE); - return logfs_get_sb_mtd(p, type, flags, mtdnr, mnt); + return logfs_get_sb_mtd(p, mtdnr); } p->s_bdev = bdev; p->s_mtd = NULL; p->s_devops = &bd_devops; - - return logfs_get_sb_device(p, type, flags, mnt); + return 0; } -- cgit v1.2.3 From e5a0726a953daf224ae42bcf5edaa64f71b4e8a7 Mon Sep 17 00:00:00 2001 From: Al Viro Date: Mon, 26 Jul 2010 12:06:00 +0400 Subject: logfs: fix a leak in get_sb a) switch ->put_device() to logfs_super * b) actually call it on early failures in logfs_get_sb_device() Signed-off-by: Al Viro --- fs/logfs/dev_bdev.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'fs/logfs/dev_bdev.c') diff --git a/fs/logfs/dev_bdev.c b/fs/logfs/dev_bdev.c index 223b673dcc7b..92ca6fbe09bd 100644 --- a/fs/logfs/dev_bdev.c +++ b/fs/logfs/dev_bdev.c @@ -298,9 +298,9 @@ static int bdev_write_sb(struct super_block *sb, struct page *page) return sync_request(page, bdev, WRITE); } -static void bdev_put_device(struct super_block *sb) +static void bdev_put_device(struct logfs_super *s) { - close_bdev_exclusive(logfs_super(sb)->s_bdev, FMODE_READ|FMODE_WRITE); + close_bdev_exclusive(s->s_bdev, FMODE_READ|FMODE_WRITE); } static int bdev_can_write_buf(struct super_block *sb, u64 ofs) -- cgit v1.2.3