summaryrefslogtreecommitdiff
path: root/scripts/tracing
diff options
context:
space:
mode:
authorJoe Perches <joe@perches.com>2014-01-23 15:54:43 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2014-01-23 16:36:57 -0800
commitc34c09a8451fac8555cbf0e8df1f6cf31cf1360b (patch)
treec02d5fc86654daa828f610a3d212f899ae6dee7d /scripts/tracing
parent7e4915e78992ebd3cc031051dc23063bbf29e749 (diff)
checkpatch: attempt to find missing switch/case break;
switch case statements missing a break statement are an unfortunately common error. e.g.: commit 4a2c94c9b6c0 ("HID: kye: Add report fixup for Genius Manticore Keyboard") case blocks should end in a break/return/goto/continue. If a fall-through is used, it should have a comment showing that it is intentional. Ideally that comment should be something like: "/* fall-through */" Add a test to look for missing break statements. This looks only at the context lines before an inserted case so it's possible to have false positives when the context contains a close brace and the break is before the brace and not part of the patch context. Looking at recent patches, this is a pretty rare occurrence. The normal kernel style uses a break as the last line of the previous block. Signed-off-by: Joe Perches <joe@perche.com> Cc: Andy Whitcroft <apw@shadowen.org> Cc: Jiri Kosina <jkosina@suse.cz> Cc: Benjamin Tissoires <benjamin.tissoires@redhat.com> Cc: Dave Jones <davej@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'scripts/tracing')
0 files changed, 0 insertions, 0 deletions