summaryrefslogtreecommitdiff
path: root/samples
diff options
context:
space:
mode:
authorMark Rustad <mark.d.rustad@intel.com>2014-09-06 06:02:53 -0700
committerMatt Fleming <matt.fleming@intel.com>2014-10-03 18:41:01 +0100
commitb2fce819a841eed21034c10a6fe3a8f43532dfb2 (patch)
tree1af64381ff0e6adc34e443ecb82e68b45856698e /samples
parent65ba758f3e7d99c49b5710f6010bc6ba1e50d16c (diff)
efi: Resolve some shadow warnings
It is a really bad idea to declare variables or parameters that have the same name as common types. It is valid C, but it gets surprising if a macro expansion attempts to declare an inner local with that type. Change the local names to eliminate the hazard. Change s16 => str16, s8 => str8. This resolves warnings seen when using W=2 during make, for instance: drivers/firmware/efi/vars.c: In function ‘dup_variable_bug’: drivers/firmware/efi/vars.c:324:44: warning: declaration of ‘s16’ shadows a global declaration [-Wshadow] static void dup_variable_bug(efi_char16_t *s16, efi_guid_t *vendor_guid, drivers/firmware/efi/vars.c:328:8: warning: declaration of ‘s8’ shadows a global declaration [-Wshadow] char *s8; Signed-off-by: Mark Rustad <mark.d.rustad@intel.com> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com> Signed-off-by: Matt Fleming <matt.fleming@intel.com>
Diffstat (limited to 'samples')
0 files changed, 0 insertions, 0 deletions