diff options
author | YueHaibing <yuehaibing@huawei.com> | 2019-03-14 13:47:59 +0800 |
---|---|---|
committer | David S. Miller <davem@davemloft.net> | 2019-03-15 11:25:48 -0700 |
commit | 9804501fa1228048857910a6bf23e085aade37cc (patch) | |
tree | d51cf99870eb02f0b90107a449586d2ab20dbe9e /include/linux/atalk.h | |
parent | f261c4e529dac5608a604d3dd3ae1cd2adf23c89 (diff) |
appletalk: Fix potential NULL pointer dereference in unregister_snap_client
register_snap_client may return NULL, all the callers
check it, but only print a warning. This will result in
NULL pointer dereference in unregister_snap_client and other
places.
It has always been used like this since v2.6
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/atalk.h')
-rw-r--r-- | include/linux/atalk.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/atalk.h b/include/linux/atalk.h index d5cfc0b15b76..f6034ba774be 100644 --- a/include/linux/atalk.h +++ b/include/linux/atalk.h @@ -108,7 +108,7 @@ static __inline__ struct elapaarp *aarp_hdr(struct sk_buff *skb) #define AARP_RESOLVE_TIME (10 * HZ) extern struct datalink_proto *ddp_dl, *aarp_dl; -extern void aarp_proto_init(void); +extern int aarp_proto_init(void); /* Inter module exports */ |