summaryrefslogtreecommitdiff
path: root/drivers/net/bonding
diff options
context:
space:
mode:
authorKrzysztof Piotr Oledzki <ole@ans.pl>2010-10-06 14:28:22 -0700
committerDavid S. Miller <davem@davemloft.net>2010-10-06 14:28:22 -0700
commit546add79468183f266c75c632c96e4b0029e0d96 (patch)
tree1be2cca38edc0d2fdc2f5fc2c9cdddb0585cbaa3 /drivers/net/bonding
parent700c2a779e6d5a60e2ef4716e75ea7f41546602f (diff)
bonding: reread information about speed and duplex when interface goes up
When an interface was enslaved when it was down, bonding thinks it has speed -1 even after it goes up. This leads into selecting a wrong active interface in active/backup mode on mixed 10G/1G or 1G/100M environment. before: bonding: bond0: link status definitely up for interface eth5, 100 Mbps full duplex. bonding: bond0: link status definitely up for interface eth0, 100 Mbps full duplex. after: bonding: bond0: link status definitely up for interface eth5, 10000 Mbps full duplex. bonding: bond0: link status definitely up for interface eth0, 1000 Mbps full duplex. Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl> Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'drivers/net/bonding')
-rw-r--r--drivers/net/bonding/bond_main.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c
index e498ce3defad..d5004826d19e 100644
--- a/drivers/net/bonding/bond_main.c
+++ b/drivers/net/bonding/bond_main.c
@@ -2406,6 +2406,8 @@ static void bond_miimon_commit(struct bonding *bond)
slave->state = BOND_STATE_BACKUP;
}
+ bond_update_speed_duplex(slave);
+
pr_info("%s: link status definitely up for interface %s, %d Mbps %s duplex.\n",
bond->dev->name, slave->dev->name,
slave->speed, slave->duplex ? "full" : "half");