summaryrefslogtreecommitdiff
path: root/drivers/ata/pata_icside.c
diff options
context:
space:
mode:
authorMark Lord <liml@rtr.ca>2008-02-21 15:52:25 -0500
committerJeff Garzik <jeff@garzik.org>2008-02-24 00:28:23 -0500
commit39f25e70ca37b8a719e8274e6f3ec2ce2ea8df04 (patch)
tree5462aab37b324f239015ad025f443669014128ca /drivers/ata/pata_icside.c
parent9116300634c5c76cfcd0d2af689846e04d172256 (diff)
libata-pmp: clear hob for pmp register accesses
>> Mark Lord wrote: >>> Tejun, I've added PMP to sata_mv, and am now trying to get it >>> to work with a Marvell PM attached. >>> >>> And the behaviour I see is very bizarre. >>> >>> After hard+soft resets, the PM signature is found, >>> and libata interrogates the PM registers. >>> >>> It successfully reads register 0, and then register 1. >>> But all subsequent registers read out (incorrectly) as zeros. ... This behavior has been confirmed by Marvell with a SATA analyzer. The Marvell port-multiplier apparently likes to see clean HOB information when accessing PMP registers. Since sata_mv uses PIO shadow register access, this doesn't happen automatically, as it might in a more purely FIS-based driver (eg. ahci). One way to fix this is to flag these commands with ATA_TFLAG_LBA48, forcing libata to write out the HOB fields with known (zero) values. Signed-off-by: Saeed Bishara <saeed@marvell.com> Acked-by: Mark Lord <mlord@pobox.com> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Diffstat (limited to 'drivers/ata/pata_icside.c')
0 files changed, 0 insertions, 0 deletions