summaryrefslogtreecommitdiff
path: root/Documentation/sh
diff options
context:
space:
mode:
authorSteven Noonan <steven@uplinklabs.net>2014-02-12 23:01:07 -0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2014-02-22 13:34:57 -0800
commit2ae24ea8ea78574ba0af8e21f8b7584023397bef (patch)
tree57ac5bd3e6896cff573f05ea038e6e9391e85387 /Documentation/sh
parentf7e3b4563a05f5e1354cb7e1de9d356e76d059e4 (diff)
compiler/gcc4: Make quirk for asm_volatile_goto() unconditional
commit a9f180345f5378ac87d80ed0bea55ba421d83859 upstream. I started noticing problems with KVM guest destruction on Linux 3.12+, where guest memory wasn't being cleaned up. I bisected it down to the commit introducing the new 'asm goto'-based atomics, and found this quirk was later applied to those. Unfortunately, even with GCC 4.8.2 (which ostensibly fixed the known 'asm goto' bug) I am still getting some kind of miscompilation. If I enable the asm_volatile_goto quirk for my compiler, KVM guests are destroyed correctly and the memory is cleaned up. So make the quirk unconditional for now, until bug is found and fixed. Suggested-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Steven Noonan <steven@uplinklabs.net> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Steven Rostedt <rostedt@goodmis.org> Cc: Jakub Jelinek <jakub@redhat.com> Cc: Richard Henderson <rth@twiddle.net> Cc: Andrew Morton <akpm@linux-foundation.org> Cc: Oleg Nesterov <oleg@redhat.com> Link: http://lkml.kernel.org/r/1392274867-15236-1-git-send-email-steven@uplinklabs.net Link: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58670 Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'Documentation/sh')
0 files changed, 0 insertions, 0 deletions