summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorYang Li <yang.lee@linux.alibaba.com>2022-01-19 09:04:32 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-02-08 18:34:14 +0100
commit7c0ee51fe998567f005b7f949a6e7f0f8320e0bb (patch)
tree95c838061e987366c9456ced559f2c39f43cbe9b
parent3d631a1af0d73c3338c4bc8b5964abc457e04d89 (diff)
gpio: mpc8xxx: Fix an ignored error return from platform_get_irq()
commit 9f51ce0b9e73f83bab2442b36d5e247a81bd3401 upstream. The return from the call to platform_get_irq() is int, it can be a negative error code, however this is being assigned to an unsigned int variable 'irqn', so making 'irqn' an int. Eliminate the following coccicheck warning: ./drivers/gpio/gpio-mpc8xxx.c:391:5-21: WARNING: Unsigned expression compared with zero: mpc8xxx_gc -> irqn < 0 Reported-by: Abaci Robot <abaci@linux.alibaba.com> Fixes: 0b39536cc699 ("gpio: mpc8xxx: Fix IRQ check in mpc8xxx_probe") Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/gpio/gpio-mpc8xxx.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/gpio/gpio-mpc8xxx.c b/drivers/gpio/gpio-mpc8xxx.c
index 01634c8d27b3..a964e25ea620 100644
--- a/drivers/gpio/gpio-mpc8xxx.c
+++ b/drivers/gpio/gpio-mpc8xxx.c
@@ -47,7 +47,7 @@ struct mpc8xxx_gpio_chip {
unsigned offset, int value);
struct irq_domain *irq;
- unsigned int irqn;
+ int irqn;
};
/*