diff options
| author | Rasmus Villemoes <linux@rasmusvillemoes.dk> | 2015-01-14 16:10:12 +0000 |
|---|---|---|
| committer | David Howells <dhowells@redhat.com> | 2015-01-14 16:10:12 +0000 |
| commit | b9f918a31d629e99c9ca3d6ac2a2d7a905715c69 (patch) | |
| tree | baaca0718341de9349805593023944b62336122a | |
| parent | 98dbbcba1b0c1874b9faf9c77b83f9729360aa2c (diff) | |
MPILIB: Fix comparison of negative MPIs
If u and v both represent negative integers and their limb counts
happen to differ, mpi_cmp will always return a positive value - this
is obviously bogus. u is smaller than v if and only if it is larger in
absolute value.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Dmitry Kasatkin <dmitry.kasatkin@gmail.com>
| -rw-r--r-- | lib/mpi/mpi-cmp.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/mpi/mpi-cmp.c b/lib/mpi/mpi-cmp.c index 8ed36b8cbe02..d25e9e96c310 100644 --- a/lib/mpi/mpi-cmp.c +++ b/lib/mpi/mpi-cmp.c @@ -57,7 +57,7 @@ int mpi_cmp(MPI u, MPI v) if (usize != vsize && !u->sign && !v->sign) return usize - vsize; if (usize != vsize && u->sign && v->sign) - return vsize + usize; + return vsize - usize; if (!usize) return 0; cmp = mpihelp_cmp(u->d, v->d, usize); |