diff options
| author | Justin Chadwell <justin.chadwell@arm.com> | 2019-07-03 14:15:22 +0100 |
|---|---|---|
| committer | Justin Chadwell <justin.chadwell@arm.com> | 2019-07-12 09:12:19 +0100 |
| commit | 3e43121ed16996758342aafdc42806ea2a0fe181 (patch) | |
| tree | a8dcf10c220f1120542143c54abd4d8eb5e2da94 | |
| parent | d3b6df7c3b0db0c5791dd92b66f195a601d69559 (diff) | |
Update base code to not rely on undefined overflow behaviour
This consists of ensuring that the left operand of each shift is
unsigned when the operation might overflow into the sign bit.
Change-Id: Iddd6f38139a4c6e500468b4fc48d04e0939f574e
Signed-off-by: Justin Chadwell <justin.chadwell@arm.com>
| -rw-r--r-- | include/drivers/ufs.h | 2 | ||||
| -rw-r--r-- | lib/xlat_tables/aarch32/nonlpae_tables.c | 4 |
2 files changed, 3 insertions, 3 deletions
diff --git a/include/drivers/ufs.h b/include/drivers/ufs.h index a10cd803..574c4ea0 100644 --- a/include/drivers/ufs.h +++ b/include/drivers/ufs.h @@ -82,7 +82,7 @@ #define UECDME 0x48 /* UTP Transfer Request Interrupt Aggregation Control Register */ #define UTRIACR 0x4C -#define UTRIACR_IAEN (1 << 31) +#define UTRIACR_IAEN (1U << 31) #define UTRIACR_IAPWEN (1 << 24) #define UTRIACR_IASB (1 << 20) #define UTRIACR_CTR (1 << 16) diff --git a/lib/xlat_tables/aarch32/nonlpae_tables.c b/lib/xlat_tables/aarch32/nonlpae_tables.c index eca3be3f..e31f9d84 100644 --- a/lib/xlat_tables/aarch32/nonlpae_tables.c +++ b/lib/xlat_tables/aarch32/nonlpae_tables.c @@ -122,8 +122,8 @@ CASSERT(PLAT_PHY_ADDR_SPACE_SIZE == (1ULL << 32), invalid_paddr_space_size); #define DACR_DOMAIN_PERM_CLIENT 0x1 #define DACR_DOMAIN_PERM_MANAGER 0x3 -#define NUM_1MB_IN_4GB (1 << 12) -#define NUM_4K_IN_1MB (1 << 8) +#define NUM_1MB_IN_4GB (1U << 12) +#define NUM_4K_IN_1MB (1U << 8) #define ONE_MB_SHIFT 20 |