diff options
| author | Ye Li <ye.li@nxp.com> | 2020-08-04 00:04:58 -0700 |
|---|---|---|
| committer | Ye Li <ye.li@nxp.com> | 2020-08-04 03:17:17 -0700 |
| commit | dbd4674bc8d3cc4991df888f971140c68cef32b5 (patch) | |
| tree | b61ef2a86f96a62b644f16415bbf7c93e0a70136 /drivers | |
| parent | 85dac0df94ac74be37ec688a0e2e69e2260be752 (diff) | |
LF-1851 fastboot: getvar: Fix dereference null return value
Fix coverity issue 3618425. In get_single_var, return value of function
find_mmc_device which returns null is dereferenced without checking
Signed-off-by: Ye Li <ye.li@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/fastboot/fb_fsl/fb_fsl_getvar.c | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/drivers/fastboot/fb_fsl/fb_fsl_getvar.c b/drivers/fastboot/fb_fsl/fb_fsl_getvar.c index 4352f83461..f4808f5fe7 100644 --- a/drivers/fastboot/fb_fsl/fb_fsl_getvar.c +++ b/drivers/fastboot/fb_fsl/fb_fsl_getvar.c @@ -223,6 +223,10 @@ static int get_single_var(char *cmd, char *response) } else if (!strcmp_l1("erase-block-size", cmd)) { mmc_dev_no = mmc_get_env_dev(); mmc = find_mmc_device(mmc_dev_no); + if (!mmc) { + strncat(response, "FAILCannot get dev", chars_left); + return -1; + } blksz = get_block_size(); snprintf(response + strlen(response), chars_left, "0x%x", (blksz * mmc->erase_grp_size)); |