diff options
author | Louis Mayencourt <louis.mayencourt@arm.com> | 2019-04-09 14:11:06 +0100 |
---|---|---|
committer | Louis Mayencourt <louis.mayencourt@arm.com> | 2019-04-17 13:46:43 +0100 |
commit | 2c3b76ce7b9e36e5c8be3c454110e070a20332ca (patch) | |
tree | 040ca3fdf334a631e7d085a20e87c334c18473b9 /lib | |
parent | cba71b70ef7070bcd38a8d202f30e58f79e36c6b (diff) |
DSU: Small fix and reformat on errata framework
Change-Id: I50708f6ccc33059fbfe6d36fd66351f0b894311f
Signed-off-by: Louis Mayencourt <louis.mayencourt@arm.com>
Diffstat (limited to 'lib')
-rw-r--r-- | lib/cpus/aarch64/dsu_helpers.S | 44 |
1 files changed, 22 insertions, 22 deletions
diff --git a/lib/cpus/aarch64/dsu_helpers.S b/lib/cpus/aarch64/dsu_helpers.S index eb84daac..29870a4d 100644 --- a/lib/cpus/aarch64/dsu_helpers.S +++ b/lib/cpus/aarch64/dsu_helpers.S @@ -1,5 +1,5 @@ /* - * Copyright (c) 2018, ARM Limited and Contributors. All rights reserved. + * Copyright (c) 2019, ARM Limited and Contributors. All rights reserved. * * SPDX-License-Identifier: BSD-3-Clause */ @@ -8,20 +8,20 @@ #include <dsu_def.h> #include <lib/cpus/errata_report.h> -/* ----------------------------------------------------------------------- - * DSU erratum 936184 check function - * Checks the DSU variant, revision and configuration to determine if - * the erratum applies. Erratum applies if ACP interface is present - * in the DSU and revision-variant < r2p0. - * - * The erratum was fixed in r2p0. - * - * This function is called from both assembly and C environment. So it - * follows AAPCS. - * - * Clobbers: x0-x3 - * ----------------------------------------------------------------------- - */ + /* ----------------------------------------------------------------------- + * DSU erratum 936184 check function + * Checks the DSU variant, revision and configuration to determine if + * the erratum applies. Erratum applies if ACP interface is present + * in the DSU and revision-variant < r2p0. + * + * The erratum was fixed in r2p0. + * + * This function is called from both assembly and C environment. So it + * follows AAPCS. + * + * Clobbers: x0-x3 + * ----------------------------------------------------------------------- + */ .globl check_errata_dsu_936184 .globl errata_dsu_936184_wa @@ -41,19 +41,19 @@ func check_errata_dsu_936184 /* DSU variant and revision bitfields in CLUSTERIDR are adjacent */ ubfx x0, x1, #CLUSTERIDR_REV_SHIFT,\ #(CLUSTERIDR_REV_BITS + CLUSTERIDR_VAR_BITS) - mov x1, #(0x2 << CLUSTERIDR_REV_BITS) + mov x1, #(0x2 << CLUSTERIDR_VAR_SHIFT) cmp x0, x1 csel x0, x2, x3, hs 1: ret endfunc check_errata_dsu_936184 -/* -------------------------------------------------- - * Errata Workaround for DSU erratum #936184. - * - * Can clobber only: x0-x17 - * -------------------------------------------------- - */ + /* -------------------------------------------------- + * Errata Workaround for DSU erratum #936184. + * + * Can clobber only: x0-x17 + * -------------------------------------------------- + */ func errata_dsu_936184_wa mov x17, x30 bl check_errata_dsu_936184 |