summaryrefslogtreecommitdiff
path: root/drivers/console
diff options
context:
space:
mode:
authorJuan Castillo <juan.castillo@arm.com>2015-11-26 14:52:15 +0000
committerJuan Castillo <juan.castillo@arm.com>2016-01-21 17:27:47 +0000
commit9400b40ea4c71153a63c1f1cdaa416d45a325ec5 (patch)
tree2246537b57b322e106a2e4cc618e0958c513dad6 /drivers/console
parentf9410b47c3ea36c9c231760a85efbbb7d6e575a7 (diff)
Disable PL011 UART before configuring it
The PL011 TRM (ARM DDI 0183G) specifies that the UART must be disabled before any of the control registers are programmed. The PL011 driver included in TF does not disable the UART, so the initialization in BL2 and BL31 is violating this requirement (and potentially in BL1 if the UART is enabled after reset). This patch modifies the initialization function in the PL011 console driver to disable the UART before programming the control registers. Register clobber list and documentation updated. Fixes ARM-software/tf-issues#300 Change-Id: I839b2d681d48b03f821ac53663a6a78e8b30a1a1
Diffstat (limited to 'drivers/console')
-rw-r--r--drivers/console/console.S2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/console/console.S b/drivers/console/console.S
index b7723638..797b5645 100644
--- a/drivers/console/console.S
+++ b/drivers/console/console.S
@@ -54,7 +54,7 @@
* w1 - Uart clock in Hz
* w2 - Baud rate
* out: return 1 on success else 0 on error
- * Clobber list : x1 - x3
+ * Clobber list : x1 - x4
* -----------------------------------------------
*/
func console_init