diff options
| author | Jeenu Viswambharan <jeenu.viswambharan@arm.com> | 2018-02-16 12:07:48 +0000 |
|---|---|---|
| committer | Jeenu Viswambharan <jeenu.viswambharan@arm.com> | 2018-06-21 16:15:23 +0100 |
| commit | cdb6ac94ecb3c4caa784cd4d7580cf6252146196 (patch) | |
| tree | ca75b64e905639641e9cd00bc0d07513364afe9e /bl31 | |
| parent | e7b9473e1591d4ab375a95ebbb9256adfe9d4670 (diff) | |
SDEI: Make dispatches synchronous
SDEI event dispatches currently only sets up the Non-secure context
before returning to the caller. The actual dispatch only happens upon
exiting EL3 next time.
However, for various error handling scenarios, it's beneficial to have
the dispatch happen synchronously. I.e. when receiving SDEI interrupt,
or for a successful sdei_dispatch_event() call, the event handler is
executed; and upon the event completion, dispatcher execution resumes
after the point of dispatch. The jump primitives introduced in the
earlier patch facilitates this feature.
With this patch:
- SDEI interrupts and calls to sdei_dispatch_event prepares the NS
context for event dispatch, then sets a jump point, and immediately
exits EL3. This results in the client handler executing in
Non-secure.
- When the SDEI client completes the dispatched event, the SDEI
dispatcher does a longjmp to the jump pointer created earlier. For
the caller of the sdei_dispatch_event() in particular, this would
appear as if call returned successfully.
The dynamic workaround for CVE_2018_3639 is slightly shifted around as
part of related minor refactoring. It doesn't affect the workaround
functionality.
Documentation updated.
NOTE: This breaks the semantics of the explicit dispatch API, and any
exiting usages should be carefully reviewed.
Change-Id: Ib9c876d27ea2af7fb22de49832e55a0da83da3f9
Signed-off-by: Jeenu Viswambharan <jeenu.viswambharan@arm.com>
Diffstat (limited to 'bl31')
| -rw-r--r-- | bl31/bl31.mk | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/bl31/bl31.mk b/bl31/bl31.mk index 51a83124..307ddab6 100644 --- a/bl31/bl31.mk +++ b/bl31/bl31.mk @@ -42,7 +42,8 @@ ifeq (${SDEI_SUPPORT},1) ifeq (${EL3_EXCEPTION_HANDLING},0) $(error EL3_EXCEPTION_HANDLING must be 1 for SDEI support) endif -BL31_SOURCES += services/std_svc/sdei/sdei_event.c \ +BL31_SOURCES += services/std_svc/sdei/sdei_dispatch.S \ + services/std_svc/sdei/sdei_event.c \ services/std_svc/sdei/sdei_intr_mgmt.c \ services/std_svc/sdei/sdei_main.c \ services/std_svc/sdei/sdei_state.c |